From c70c67c264b6ec401336bd374afa195f9669d136 Mon Sep 17 00:00:00 2001
From: Santiago Lo Coco <santilococo.01@gmail.com>
Date: Mon, 24 Jan 2022 23:41:01 -0300
Subject: [PATCH] Fix SC2044 warning in linkFiles.sh

---
 scripts/linkFiles.sh | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/scripts/linkFiles.sh b/scripts/linkFiles.sh
index 88393b4..e7d0cb8 100755
--- a/scripts/linkFiles.sh
+++ b/scripts/linkFiles.sh
@@ -47,8 +47,8 @@ loopThroughFiles() {
     SADEDOT=$(pwd -P)
     DOTFILES="$SADEDOT/dotfiles"
 
-    local IFS=$'\n'
-    for srcFile in $(find -H "$DOTFILES" -maxdepth 1 -type f); do
+    local IFS=
+    while read -r -d '' srcFile; do
         if [ "$(basename "${srcFile}")" = "dotfiles" ]; then
             continue
         fi
@@ -56,10 +56,10 @@ loopThroughFiles() {
         if [[ -f "$srcFile" ]]; then
             linkFile "$srcFile" "$HOME/$(basename "${srcFile}")"
         fi
-    done
+    done < <(find -H "$DOTFILES" -maxdepth 1 -type f -print0)
 
-    for initialFolder in $(find -H "$DOTFILES" -maxdepth 1 -mindepth 1 -type d -not -path '*other*'); do
-        for srcFile in $(find -H "$initialFolder"); do
+    while read -r -d '' initialFolder; do
+        while read -r -d '' srcFile; do
             if [[ -d "$srcFile" ]]; then
                 var=$(echo "$srcFile" | awk '{ sub(/.*dotfiles\//, ""); print }')
 
@@ -72,14 +72,15 @@ loopThroughFiles() {
                 var=$(echo "$srcFile" | awk '{ sub(/.*dotfiles\//, ""); print }')
                 linkFile "$srcFile" "$HOME/$var"
             fi
-        done
-    done
+        done < <(find -H "$initialFolder" -print0)
+    done < <(find -H "$DOTFILES" -maxdepth 1 -mindepth 1 -type d -not -path '*other*' -print0)
 
     if [ -d "$DOTFILES/other" ]; then
-        filesOutput=$(find -H "$DOTFILES/other" -mindepth 1 | awk '{ sub(/.*dotfiles\/other\//, ""); print }')
-        files=""; for item in $filesOutput; do
+        files=""
+        while read -r -d '' item; do
+            item=$(echo $item | awk '{ sub(/.*dotfiles\/other\//, ""); print }')
             files="${files}$item\n"
-        done
+        done < <(find -H "$DOTFILES/other" -mindepth 1 -type f -print0)
         displayDialogBox --yesno "There are 'other' files, would you like to install them?\n\n${files}" || return
     fi
 
@@ -96,8 +97,8 @@ runDetachedScript() {
     SADEDOT=$(pwd -P)
     DOTFILES="$SADEDOT/dotfiles"
 
-    local IFS=$'\n'
-    for srcFile in $(find -H "$DOTFILES/other" -mindepth 1); do
+    local IFS=
+    while read -r -d '' srcFile; do
         if [[ -d "$srcFile" ]]; then
             var=$(echo "$srcFile" | awk '{ sub(/.*dotfiles\/other\//, ""); print }')
 
@@ -110,7 +111,7 @@ runDetachedScript() {
             var=$(echo "$srcFile" | awk '{ sub(/.*dotfiles\/other\//, ""); print }')
             linkFile "$srcFile" "/$var"
         fi
-    done
+    done < <(find -H "$DOTFILES/other" -mindepth 1 -print0)
 }
 
 runScript() {